Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scan type in webhook event #20363

Merged
merged 1 commit into from Apr 29, 2024
Merged

Conversation

stonezdj
Copy link
Contributor

fixes #20331

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Copy link

codecov bot commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 36.36364% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 66.36%. Comparing base (b7b8847) to head (2288d45).
Report is 169 commits behind head on main.

❗ Current head 2288d45 differs from pull request most recent head 44d28e9. Consider uploading reports for the commit 44d28e9 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #20363      +/-   ##
==========================================
- Coverage   67.56%   66.36%   -1.20%     
==========================================
  Files         991     1042      +51     
  Lines      109181   113080    +3899     
  Branches     2719     2828     +109     
==========================================
+ Hits        73768    75051    +1283     
- Misses      31449    33972    +2523     
- Partials     3964     4057      +93     
Flag Coverage Δ
unittests 66.36% <36.36%> (-1.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/controller/event/metadata/scan.go 92.59% <100.00%> (+0.28%) ⬆️
src/controller/event/topic.go 6.47% <ø> (ø)
src/controller/scan/callback.go 60.86% <0.00%> (-3.75%) ⬇️
src/controller/event/handler/webhook/scan/scan.go 51.00% <41.17%> (-1.28%) ⬇️

... and 570 files with indirect coverage changes

@stonezdj stonezdj force-pushed the 24apr25_scan_event branch 2 times, most recently from 8eab709 to 2288d45 Compare April 29, 2024 07:25
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

   fixes goharbor#20331

Signed-off-by: stonezdj <stone.zhang@broadcom.com>
@stonezdj stonezdj merged commit d154c27 into goharbor:main Apr 29, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scan failed event needs to be updated for supporting SBOM
7 participants