Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UI sbom status not updated to grid item after job done #20368

Merged
merged 1 commit into from Apr 29, 2024
Merged

Fix UI sbom status not updated to grid item after job done #20368

merged 1 commit into from Apr 29, 2024

Conversation

xuelichao
Copy link
Contributor

After the job of generating SBOM is done, the sbom overview status is not updated to the proper artifact item in the grid.
This PR update the latest sbom_overview and sbom_digest to the proper artifact.

Issue being fixed

Fixes #20320

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@xuelichao xuelichao requested a review from a team as a code owner April 27, 2024 10:52
@xuelichao xuelichao force-pushed the sbom-ui branch 2 times, most recently from addf8b8 to b95ef02 Compare April 27, 2024 10:56
@xuelichao xuelichao added the release-note/ignore-for-release Do not include PR or Issue for release notes label Apr 27, 2024
@codecov Codecov
Copy link

codecov bot commented Apr 27, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.22%. Comparing base (b7b8847) to head (3f55356).
Report is 168 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #20368       +/-   ##
===========================================
- Coverage   67.56%   46.22%   -21.35%     
===========================================
  Files         991      247      -744     
  Lines      109181    13749    -95432     
  Branches     2719     2830      +111     
===========================================
- Hits        73768     6355    -67413     
+ Misses      31449     7070    -24379     
+ Partials     3964      324     -3640
Flag Coverage Δ
unittests 46.22% <ø> (-21.35%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1238 files with indirect coverage changes

wy65701436
wy65701436 approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@xuelichao
Fix UI sbom status not updated after job done
3f55356 
Signed-off-by: xuelichao <xuel@vmware.com>
@xuelichao xuelichao merged commit 9b5dd79 into goharbor:main Apr 29, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wy65701436 wy65701436 wy65701436 approved these changes

@zyyw zyyw zyyw approved these changes

Assignees

@Vad1mo Vad1mo

@wy65701436 wy65701436

@chlins chlins

Labels
release-note/ignore-for-release Do not include PR or Issue for release notes target/2.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI contine querying the sbom overview even the task has done
5 participants
@xuelichao @wy65701436 @zyyw @Vad1mo @chlins