Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing Query.Sorting as it we are deprecating it #19569

Open
zyyw opened this issue Nov 13, 2023 · 2 comments · May be fixed by #19962
Open

Removing Query.Sorting as it we are deprecating it #19569

zyyw opened this issue Nov 13, 2023 · 2 comments · May be fixed by #19962
Assignees
@zyyw
Labels
Stale

Comments

@zyyw
Copy link
Contributor

zyyw commented Nov 13, 2023 •
edited

How can we help you?
Since we are deprecating Query.Sorting, let's remove the corresponding logic that's still using Query.Sorting.

harbor/src/lib/q/query.go

Lines 30 to 31 in 219e4ba

// Deprecate, use "Sorts" instead
Sorting string

@github-actions GitHub Actions
Copy link

This issue is being marked stale due to a period of inactivity. If this issue is still relevant, please comment or remove the stale label. Otherwise, this issue will close in 30 days.

@github-actions github-actions bot added the Stale label Jan 26, 2024
@Its-Maniaco Its-Maniaco linked a pull request Feb 6, 2024 that will close this issue
Open
@Vad1mo Vad1mo removed the Stale label Feb 12, 2024
@github-actions GitHub Actions
Copy link

This issue is being marked stale due to a period of inactivity. If this issue is still relevant, please comment or remove the stale label. Otherwise, this issue will close in 30 days.

@github-actions github-actions bot added the Stale label Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zyyw zyyw

Labels
Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove query.Sorting from registration.go Its-Maniaco/harbor
2 participants
@Vad1mo @zyyw