Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add client IP for audit logs #18675

Open
NitroCao opened this issue May 12, 2023 · 4 comments · May be fixed by #19725
Open

Add client IP for audit logs #18675

NitroCao opened this issue May 12, 2023 · 4 comments · May be fixed by #19725
Labels
kind/requirement New feature or idea on top of harbor

Comments

@NitroCao
Copy link

Currently audit logs don't contain client IP, which isn't enough for security audit. Can we add it for audit log?
@chlins chlins added the kind/requirement New feature or idea on top of harbor label May 15, 2023
@chlins
Copy link
Member

chlins commented May 15, 2023

Currently, the client IP is not stored in the database, but maybe it can be grabbed from the nginx or core logs.

@NitroCao
Copy link
Author

Currently, the client IP is not stored in the database, but maybe it can be grabbed from the nginx or core logs.

Yeah Nginx logs contain client IPs but it's difficult to associate them with corresponding accounts.
I just found related issues:

@lengrongfu
Copy link
Contributor

@chlins I think this is valuable, do you agree to do it? If yes, I can contribute.

@dioguerra
Copy link

dioguerra commented Jun 21, 2023 •
edited

Any news on this...

This is important to track security related issues...

I can try and fix this, if you think it's a good first issue.

@NitroCao NitroCao linked a pull request Jan 5, 2024 that will close this issue
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/requirement New feature or idea on top of harbor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add option to store IP-Addresses and/or user-agents details in audit logs container-registry/harbor
4 participants
@dioguerra @lengrongfu @NitroCao @chlins