Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable anonymous user #10760

Open
MaGaoju opened this issue Feb 19, 2020 · 13 comments
Open

Disable anonymous user #10760

MaGaoju opened this issue Feb 19, 2020 · 13 comments
Assignees
Labels
area/access-control doc-impact Engineering issues that will require a change in user docs kind/requirement New feature or idea on top of harbor

Comments

@MaGaoju
Copy link

MaGaoju commented Feb 19, 2020

we are using Harbor internally and using OIDC provider for the auth. we don't want anonymous access for this instance. we'd like to keep all public project only accessible by authed users. it's possible to make this configurable ? if code change needed, anyone can help to share this changes?

thx!

@cafeliker
Copy link

@reasonerjt I am reading the Harbor codes, could you pls help check if we can remove this section to disable the anonymous access?
image

https://github.com/goharbor/harbor/blob/v1.10.1/src/core/api/project.go#L406

Thanks
ye

@steven-zou steven-zou added area/access-control kind/requirement New feature or idea on top of harbor labels Feb 20, 2020
@steven-zou
Copy link
Contributor

@xaleeks

Obviously, this is a requirement and then needs the decision from PM.

@cafeliker
Copy link

Anonymous access is good for community purpose; and for Enterprise, the public repo should be only visible for authenticated people to protect the content and IP - so pls add the configuration item to enable/disable anonymous.

Before it's available, can we quickly fork and make some changes as I proposed above? Do you think it's the only place I need to change?

Thank you again for such great open source software.

ye

@renmaosheng
Copy link
Contributor

I got a similar request from "Xing ye Yin hang".

@cafeliker
Copy link

I submitted a PR #10825.

Thanks
ye

@xaleeks
Copy link
Contributor

xaleeks commented Feb 24, 2020

agreed, makes sense for a lot of customers

@xaleeks xaleeks self-assigned this Feb 24, 2020
@xaleeks xaleeks added the doc-impact Engineering issues that will require a change in user docs label Feb 24, 2020
@reasonerjt
Copy link
Contributor

I agree it's a valid requirement but we should put it in the pipeline and write proposal, then target it to a release, no?

@cafeliker
Copy link

I will make the document, thanks for your information.

@cafeliker
Copy link

@xaleeks I created the document with a PR in the harbor community repo at goharbor/community#124.

Thanks
ye

@xaleeks
Copy link
Contributor

xaleeks commented Feb 29, 2020

@cafeliker Thanks, I think it looks good.

@xaleeks xaleeks added this to Backlog in Harbor Project Board via automation Apr 18, 2020
@xaleeks xaleeks moved this from Backlog to 2.1 Product Suggestions in Harbor Project Board Apr 18, 2020
@xaleeks xaleeks moved this from 2.1 Product Commitments to Backlog in Harbor Project Board Nov 27, 2020
@github-actions
Copy link

github-actions bot commented Jul 7, 2022

This issue is being marked stale due to a period of inactivity. If this issue is still relevant, please comment or remove the stale label. Otherwise, this issue will close in 30 days.

@github-actions github-actions bot added Stale and removed Stale labels Jul 7, 2022
@sdileepkumarreddy
Copy link

Hi Any update in this feature? Would be nice to have this for handling some analytics

@shreekanthDev
Copy link

Hello Team, any update on this feature implementation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/access-control doc-impact Engineering issues that will require a change in user docs kind/requirement New feature or idea on top of harbor
Projects
Development

No branches or pull requests

8 participants