Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trivy usage of existingClaim PVC fails with many replicas #1452

Closed
dioguerra opened this issue Mar 24, 2023 · 2 comments
Closed

Trivy usage of existingClaim PVC fails with many replicas #1452

dioguerra opened this issue Mar 24, 2023 · 2 comments

Comments

@dioguerra
Copy link
Contributor

While using trivy statefulset, if we use existentClaim there is nothing that
warns or forbids the issue that multiple instances of trivy cannot access the same pvc (at the same time)

aquasecurity/trivy#3894

I think we should limit the usage of a PVC with trivy and validate that this is only allowed when trivy.replicas <= 1

Otherwise, users need to use the StorageClass so that we can use the VolumeTemplates or otherwise emptyDir with the possibility of sharing state via the (still under testing) REDIS cache.

I'm not sure that this is solvable with the accessMode: ReadWriteOnce + multiplePods + existingClaim

  • If it is, the accessMode should be blocked to ReadWriteOnce.
  • I think, just drop this definition from the configuration as this will always be the case (only one pod should have access the PVC at a time) independent of the claim type
Copy link

github-actions bot commented Feb 8, 2024

This issue is being marked stale due to a period of inactivity. If this issue is still relevant, please comment or remove the stale label. Otherwise, this issue will close in 30 days.

@github-actions github-actions bot added the Stale label Feb 8, 2024
Copy link

This issue was closed because it has been stalled for 30 days with no activity. If this issue is still relevant, please re-open a new issue.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants