Empty configuration during create panics the binary, but ideally should output actionable data

[AbhinavMir]

hi! I was trying to set this up and seems like credential resolution panics the binary instead of outputting something like "Empty ~/,harbor/config, please " - the patch for this is rather easy, should I start a PR or is this a candidate for the mentorship program?

Cheers and thanks!
Abhinav.

[JaeAeich]

Hey @AbhinavMir and @Vad1mo.
I was just checking in on the issue, wanted to see if this is an OK solution :) (if so let me know I'll create a PR)
Given the error we can have at this point are regarding config issues it would make sense to exit quitely.

//pkg/utils/credential_store.go

func resolveCredential(credentialName string) (Credential, error) {
	credentialStore, err := readCredentialStore()
	if err != nil {
		return Credential{}, fmt.Errorf("failed to read credential store: %s", err)
	}

...
	if credentialName == "" {
		return Credential{}, fmt.Errorf("current credential name not set, please login again")
	}
...
	return Credential{}, fmt.Errorf("no credential found for the name: %s, please login again with the credential name: %s", credentialName, credentialName)
}

//pkg/utils/utils.go
func GetClientByCredentialName(credentialName string) *v2client.HarborAPI {
	credential, err := resolveCredential(credentialName)
	if err != nil {
		fmt.Print(err) // If error come from resolveCredential, it make sense to exist and print the user friendly message.
		os.Exit(1)
	}
...
}

[amands98]

already fixed
// @Vad1mo