Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harbor Login, Name of Credential should not be mandatory #37

Open
Vad1mo opened this issue Apr 10, 2024 · 4 comments
Open

Harbor Login, Name of Credential should not be mandatory #37

Vad1mo opened this issue Apr 10, 2024 · 4 comments

Comments

@Vad1mo
Copy link
Member

Vad1mo commented Apr 10, 2024

Why is Name of Credential mandatory?

What are the use cases where a user needs to set Name of Credential
Also, why can the name of credential not be generated as eg. user@registry.domain.com

./harbor login 8gears.container-registry.com
  Server                                                                                                                                                                                                                                                                                                      
  > 8gears.container-registry.com                                                                                                                                                                                                                                                                             
                                                                                                                                                                                                                                                                                                              
  User Name                                                                                                                                                                                                                                                                                                   
  > vadim                                                                                                                                                                                                                                                                                                     
                                                                                                                                                                                                                                                                                                              
  Password                                                                                                                                                                                                                                                                                                    
  > *********                                                                                                                                                                                                                                                                                                 
                                                                                                                                                                                                                                                                                                              
┃ Name of Credential                                                                                                                                                                                                                                                                                          
┃ >           
@bishal7679
Copy link

@Vad1mo Then should we remove asking the name of credential entirely and make the name as user@server??

@Vad1mo
Copy link
Member Author

Vad1mo commented Apr 15, 2024

I was thinking the same but I didn't want to push my opinion too much, not knowing the details

@amands98
Copy link
Contributor

amands98 commented Apr 16, 2024

We can automatically generate the credential name based on the server name and username.

@amands98
Copy link
Contributor

I think credential name should be required *.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants