Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate Dagger instead of Make/GH Action #22

Open
Vad1mo opened this issue Feb 16, 2024 · 3 comments
Open

Evaluate Dagger instead of Make/GH Action #22

Vad1mo opened this issue Feb 16, 2024 · 3 comments

Comments

@Vad1mo
Copy link
Member

Vad1mo commented Feb 16, 2024

This is not one of the top priorities, but in my opinion it would make sense to replace the Makefile and large part of the workflows with https://dagger.io/

Some benefits I see

  • Easy way to spin up a local env from scratch,
  • better end-to-end testing
@bishal7679
Copy link

Nice One!
tried once but not implemented. Let's write a script with it

@Vad1mo Vad1mo changed the title Experiment With Dagger instead of Make Evaluate Dagger instead of Make/GH Action Feb 17, 2024
@amands98
Copy link
Contributor

My take ->
Considering infrequent CI system changes, introducing Dagger as an intermediary layer may not be necessary if you switch systems rarely.

I see fewer projects adopting Dagger.

https://medium.com/devstream/an-honest-look-at-dagger-fae07986bfc1

@JaeAeich
Copy link
Contributor

JaeAeich commented Mar 9, 2024

The main issue I see is the logs, with GH actions it is easier for the team to figure out the problem from the logs on github itself, rather than going and running locally. Plus there won't be enough granularity in "task"/"actions" anymore, yeah we can run them individually if we want to do it on gh actions but that means for us to again write workflows which brings us back to square 1. The biggest advantage of dagger I see is being able to run pipelines locally but if someone cared that much they can do so with ACT. And the other cool feature it CUE and being able to generate containers without a set Dockerfile but with code, which might be useful but the tradeoff imo outweighs the other challenges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants