Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Course Continue Button is not displayed to non-enrolled students regardless of the enrollment visibility setting. #2619

Open
2 of 4 tasks
dominiquemariano opened this issue Mar 26, 2024 · 2 comments
Assignees

Comments

@dominiquemariano
Copy link

dominiquemariano commented Mar 26, 2024

Reproduction Steps

  1. Create a new course.
  2. Add the Course Continue Button to the course page.
  3. Observe that the Enrollment Visibility setting is set to Everyone.

Expected Behavior

The Enrollment Visibility setting should not have Everyone in the options. Alternatively, it should not have Enrollment Visibility at all.

Actual Behavior

The Enrollment Visibility setting has Everyone in the options. But, the Course Continue Button or the Get Started button will not visible on the front-end for non-logged in users, as expected.

Since the Get Started is tied to some logic (it relies on looking up what progress the student is on the course so it knows which lesson to link to), we should make sure that the Enrollment Visibility setting does not contain Everyone as an option since that confuses users.

This issue has be recreated:

  • Locally
  • On a staging site
  • On a production website
  • With only LifterLMS and a default theme
@ideadude ideadude self-assigned this Mar 26, 2024
@dominiquemariano
Copy link
Author

Reporting ticket is HS-240825.

@shutathis
Copy link

Comment from Kim:

I think we should probably rather remove the visibility setting from that block.
That block has other logic to only show if the student is enrolled. If the student isn’t enrolled, where would someone expect the button to go? We rely on looking up their progress in the course.

I have updated Expected Behavior and Actual Behavior as a result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Awaiting Triage
Development

No branches or pull requests

3 participants