-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All Non-Relational Privatizations except Miné-W unsound #1457
Comments
For protection, the problem seems to be that both get added to |
Lines 1735 to 1743 in 5cd8650
In the |
michael-schwarz
added a commit
that referenced
this issue
May 13, 2024
Earlier `priv` was not joined over, which lead to unsound results #1457. On top, this also considers `dep` and `weak`. While not strictly necessary to pass tests, this also seems to be the right thing here.
michael-schwarz
added a commit
that referenced
this issue
May 13, 2024
michael-schwarz
added a commit
that referenced
this issue
May 13, 2024
Earlier `priv` was not joined over, which lead to unsound results #1457. On top, this also considers `dep` and `weak`. While not strictly necessary to pass tests, this also seems to be the right thing here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
During #1456 I discovered that, in fact, all of our non-relational privatizations except the one casting Miné's analsysis in our framework are unsound.
The problem is that upon setting
*ptr = 5
, all targets in the may-point-to-set are updated, rather than joining together the result of updating the different targets. This is likely due to some bot/top confusion inside the local states of the base analysis where the non-present bindings are all assumed to be \bot.The text was updated successfully, but these errors were encountered: