Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ApiValidatorAttestationEfficiency does not return pubKey as it used to do sometime ago #2799

Open
luarx opened this issue Jan 5, 2024 · 3 comments

Comments

@luarx
Copy link

luarx commented Jan 5, 2024

Describe the bug
When requesting /api/v1/validator/{Pubkey}/attestationefficiency it returns for each element the validatorindex BUT not the pubkey

Some time ago, /api/v1/validator/{Pubkey}/attestationeffectiveness (now deprecated in favor of /api/v1/validator/{Pubkey}/attestationefficiency) returned the pubkey for each requested validators
Reference commit where the behaviour changed:
image

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
/api/v1/validator/{Pubkey}/attestationefficiency should return the pubkey field for each requested validator (at least if a pubkey or a list of pubkeys are used).
/api/v1/validator/{Index}/attestationefficiency can return also the pubkey or not (in my opinion, for consistency it should also)

Example:
Request: /api/v1/validator/pubkey_1,pubkey_2/attestationefficiency
Response:

{"status":"OK",
"data":[
{"validatorindex":2,"attestation_efficiency":1.0066666666666668},
{"validatorindex":1,"attestation_efficiency":1.005}
]
}

In the last example I am requesting using pubkeys and not validatorindex, so it is difficult to match each element of the data field with the right validator without doint more logic.

The expected behaviour in case that it is possible, should be:
Request: /api/v1/validator/pubkey_1,pubkey_2/attestationefficiency
Response:

{"status":"OK",
"data":[
{"validatorpubkey": pubkey_2, "validatorindex":2,"attestation_efficiency":1.0066666666666668},
{"validatorpubkey": pubkey_1, "validatorindex":1,"attestation_efficiency":1.005}
]
}
@Rubytues123
Copy link

Pubby

@Rubytues123
Copy link

Hey

@luarx
Copy link
Author

luarx commented Mar 4, 2024

Could we push this issue? 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@luarx @Rubytues123 and others