Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API 10] Migration to EXDSchema #1785

Open
KazWolfe opened this issue Apr 21, 2024 · 1 comment
Open

[API 10] Migration to EXDSchema #1785

KazWolfe opened this issue Apr 21, 2024 · 1 comment
Labels
dependencies Pull requests that update a dependency file needs api bump Held for the next API bump plugin-api About or affects the Plugin API

Comments

@KazWolfe
Copy link
Member

Note

This Issue is based in Lumina rather than Dalamud, but exists here for tracking and auditing purposes. If there are any known issues with moving to EXDSchama from a plugin perspective, please document them here.

EXDSchema seems to be the preferred mechanism for accessing EXD data in Lumina now, but it is currently named GeneratedSheets2. With API 10, we have an opportunity to move it to GeneratedSheets and allow developers to update their plugins accordingly.

@KazWolfe KazWolfe added plugin-api About or affects the Plugin API needs api bump Held for the next API bump dependencies Pull requests that update a dependency file labels Apr 21, 2024
@KazWolfe KazWolfe added this to the Dalamud apiX (API 10) milestone Apr 21, 2024
@KazWolfe
Copy link
Member Author

Per Perchbird in Dalamud Discord:

there are a few actual bugs in the sheet code generation on the lumina side that need to be fixed; i forget the exact fields but there is a latent var in Achievement that shouldn't be generated and there's a nested array in CharaMakeType (i think) that is generated improperly

no, i consider those kinds of bugs to be regressions and too detrimental to replace the original impl at this moment
plus there's no telling how many more there are

This change can be safely deferred indefinitely if required, but should still be tracked with an eventual hope of targeting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file needs api bump Held for the next API bump plugin-api About or affects the Plugin API
Projects
None yet
Development

No branches or pull requests

1 participant