Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go 1.13 doesn't like this lib #46

Open
rayjlinden opened this issue Nov 12, 2019 · 5 comments
Open

Go 1.13 doesn't like this lib #46

rayjlinden opened this issue Nov 12, 2019 · 5 comments

Comments

@rayjlinden
Copy link

I'm using a library that uses "go4.org/syncutil"

The author also included this in the go.mod file:
replace go4.org v0.0.0-20190430205326-94abd6928b1d => go4.org v0.0.0-20190313082347-94abd6928b1d

I found I then also had to put the same line in my go.mod file for things to work.

So for some reason the pseudo versions generated by how you publish these modules is broken or something. Can you fix how you publish this code?

@dmitshur
Copy link
Contributor

I'm using a library that uses "go4.org/syncutil"

The author also included this in the go.mod file: replace go4.org v0.0.0-20190430205326-94abd6928b1d => go4.org v0.0.0-20190313082347-94abd6928b1d

What is the library?

@rayjlinden
Copy link
Author

@dmitshur
Copy link
Contributor

dmitshur commented Nov 12, 2019

The issue is in the ofac library.

The canonical pseudo-version for commit 94abd69 of the go4.org module is v0.0.0-20190313082347-94abd6928b1d:

$ cd $(mktemp -d)
$ GO111MODULE=on go list -m go4.org@94abd6928b1da39b1d757b60c93fb2419c409fa1
go: finding go4.org 94abd6928b1da39b1d757b60c93fb2419c409fa1
go4.org v0.0.0-20190313082347-94abd6928b1d

For some reason, that ofac library started requiring a bad pseudo-version of go4.org while also replacing the bad pseudo-version with the correct pseudo-version. Since the replace directive only works inside the main module, it has no effect when you're trying to use that library.

The right fix is in the ofac library, it should be updated to require a valid version of go4.org, such as v0.0.0-20190313082347-94abd6928b1d.

I've opened issue moov-io/watchman#167 in it.

@bradfitz
Copy link
Contributor

Thanks, @dmitshur. Closing this issue then.

@dmitshur
Copy link
Contributor

The upstream issue was fixed, see moov-io/watchman#167 (comment).

Closing this issue then.

That sounds like the right thing to do. (It hasn't been done yet.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants