Invalid client code generation for referenced enum properties

[cstaud]

Problem statement

When creating the client code for a parameter referencing an object which has a string property referencing an enum string, the go property is created as a struct instead of a (typed) string.

Swagger specification

{
  "swagger": "2.0",
  "info": {
    "title": "test",
    "version": "1"
  },
  "paths": {
    "/test": {
      "put": {
        "consumes": [
          "application/json"
        ],
        "parameters": [
          {
            "name": "test",
            "in": "body",
            "schema": {
              "$ref": "#/definitions/myParams"
            }
          }
        ],
        "responses": {
          "200": {
            "description": "OK"
          }
        }
      }
    }
  },
  "definitions": {
    "myParams": {
      "type": "object",
      "properties": {
        "myString": {
          "allOf": [
            {
              "$ref": "#/definitions/myStringEnum"
            }
          ]
        }
      }
    },
    "myStringEnum": {
      "type": "string",
      "enum": [
        "enumValue1",
        "enumValue2"
      ],
      "x-enum-varnames": [
        "EnumName1",
        "EnumName2"
      ]
    }
  }
}

Steps to reproduce

• generate the client code for the spec
• the MyParams struct has a property MyString of type struct:

type MyParams struct {

	// my string
	MyString struct {
		MyParamsMyStringAllOf0
	} `json:"myString,omitempty"`
}

• when marshaling this it results in something like: {"MyString":{"MyParamsMyStringAllOf0":"enumValue1"}} , but the spec describes something like {"MyString":"enumValue1"}

Environment

swagger version: v0.30.5
go version: 1.20.6
OS: linux

[fredbi]

Testing this on latest master and against v0.30.5, here is the generated model:

type MyParams struct {

	// my string
	MyString struct {
		MyStringEnum
	} `json:"myString,omitempty"`
}

so this looks good to me.

Notice that without the allOf nesting, the generated code is slightly better looking:

type MyParams struct {

	// my string
	MyString MyStringEnum `json:"myString,omitempty"`
}

That's because models interpret "allOf" as mechanism to compose types.
There used to be plans to "lift" simple "allOf" structures like this one in their parent, but that path was never quite completed.

[cstaud]

Hi @fredbi, thank you for your comment and sorry for the late reply.

I can confirm the generated code you gave. But that is not my point. The thing were I struggle is:
Marshalling this:

type MyParams struct {
	// my string
	MyString struct {
		MyStringEnum
	} `json:"myString,omitempty"`
}

leads to:
{"MyString":{"MyStringEnum":"enumValue1"}}

But correct would be:
{"MyString":"enumValue1"}

Note: The swagger UI handles this also correctly and results in the correct payload.