Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide more details on err #166

Open
coolapso opened this issue Nov 5, 2023 · 1 comment
Open

Provide more details on err #166

coolapso opened this issue Nov 5, 2023 · 1 comment

Comments

@coolapso
Copy link

coolapso commented Nov 5, 2023

Hello,

I've been experimenting with go-semantic-release and encountered an issue while testing and running workflows. It appears that I may have hit a rate limit. Unfortunately, when go-semantic-release exits, it doesn't provide much information. Here's what I see in the log:

[go-semantic-release]: changelog-generator plugin: default@1.13.0
[go-semantic-release]: creating release...
[go-semantic-release]: POST https://api.github.com/repos/4s3ti/streamdeck-test/git/refs: 403 Resource not accessible by integration []
[go-semantic-release]: stopping plugins...

After doing some research, I found that GitHub returns a 403 status code when a rate limit is exceeded, along with a header. You can check the rate limit details in GitHub's documentation here.

I noticed that the main library used by go-semantic-release seems to return the response from the request here. They also provide a method to check the rate limits, although it might not be directly relevant to this issue.

The relevant code in go-semantic-release's provider for GitHub can be found here. It appears that the provider is ignoring this information and relying solely on the error from the upstream library.

I'm wondering if it's feasible to capture the response and add more details to the error message so that users can better understand where the error is coming from. While I understand that rate limits shouldn't occur frequently, having additional details can be quite helpful.

I'm not very experienced with Go, but with some guidance, I'd be willing to contribute to this project by creating a pull request to address this issue. Your thoughts and insights on this would be greatly appreciated.

Edit: It was actually not a rate liming issue, rather some other misconfiguration, however the point is still valid, there is very little information about what is failing.

Thank you for your time.

@coolapso
Copy link
Author

coolapso commented Nov 5, 2023

I might have accidentally opened the issue here in the wrong place, please let me know if its okay to leave it here of if you want me to move this issue to the provider as this seems to be more related with the github provider rather than the main application itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant