Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove service/rpc1 #3250

Open
derekparker opened this issue Jan 13, 2023 · 2 comments
Open

Remove service/rpc1 #3250

derekparker opened this issue Jan 13, 2023 · 2 comments

Comments

@derekparker
Copy link
Member

The service/rpc2 package was introduced way back in 2016. I think 7 years is long enough to keep both around for the users sake.

I think we should remove the service/rpc1 package and make service/rpc2 just service/rpc and the default. We could keep the command line flag for a bit to avoid breaking clients, but we should deprecate it and also plan to eventually remove it as well.

If we find we really need to version the rpc package perhaps it belongs as a standalone package versioned via its own Go module.

@aarzilli
Copy link
Member

Do we deprecate in 1.21 and delete in 1.22? Or 1.23? I'd leave rpc2 as rpc2, in case we ever do rpc3.

@derekparker
Copy link
Member Author

@aarzilli I think deprecate in 1.21 and then remove in 1.23, give 2 releases worth of notice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants