-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ID3 Tags in the Stream #70
Comments
I'm once again less than convinced that I have fixed it afterall... |
Ugh... My results have become wildly inconsistent... I currently have an incarnation of the playlist loaded in Amarok that IS remembering the names of the songs and the artists... But still no albums... So I'm not at all sure if Amarok is simply reading those out of the M3U file, and inexplicably choosing to remember it this time, or if by some magic changing the MIME type actually changed behavior... But the lack of consistancy is making this incredibly difficult to troubleshoot... LOL, can someone else test my patch and see if it changes any behavior in any clients, or if it's just my imagination? |
Hi! I didn't think that the What to expect: if you pass to the client the URL of an M3U list, upon fetch, it can show you in the list only the details contained in the M3U file (so no Album: this the standard AFAIK). During the fetch of the current song the client COULD parse on-the-fly the ID3 tag in order to show all the metadata (included Album). In my tests, VLC doesn't parse the ID3 tag on streamed songs, but MPD does as long as Audacious (WOW!). The client COULD even decide to pre-fetch the URLS in the M3U list in order to get the missing metadata: VLC doesn't, Audicious does (WOW again). Note that the latter behavior is supported by GMusicProxy only in last release with the new multi-threading management of the requests (before no-parallel requests were managed). So Audacious is so stupid to not recognize any M3U url without the proper extension... but it is smart enough to fetch (and pre-fetch) the ID3 tags. We are talking of single beast: nothing is standard here. I did a small test switching on the Closing: convince me that the |
any news? |
First, I don't think I can prove anything interesting is happening as a result of the attachment method... And I think all of your reasoning is sound. But yes, I do think I have come to a satisfactory solution in the attached patch... It extends the ShoutCast functionality to also include fields that VLC interprets in the "Now Playing" attribute. I will call it "Experimental," as I can't find any documentation to guide me, so I have no idea if I implemented this correctly... But it seems to work in VLC and Amarok (Amarok goes a step further, and interprets the Song and Artist from that string as well). |
It doesn't seem to affect functionality, but that patch did have an extra escaped single quote in front of StreamTitle... This one doesn't. |
OK, over the last week or so, I have REALLY been digging into this tag issue... And I finally figured out the difference between our headers and the headers from internet radio stations:
Attached, please find a patch with those changes made. This is the first patch file I have ever created, so please let me know if it has any issues!
enable-streaming-id3.patch.txt
The text was updated successfully, but these errors were encountered: