Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test environment #4

Open
superbilk opened this issue Aug 13, 2017 · 3 comments
Open

Improve test environment #4

superbilk opened this issue Aug 13, 2017 · 3 comments

Comments

@superbilk
Copy link

superbilk commented Aug 13, 2017

hi, first of all thanks for that awesome gem!

you could add some insights how you run tests and use the test environment with your setup. maybe as readme or medium article.

The way I would do it is like
https://github.com/vovimayhem/docker-compose-rails-dev-example/blob/master/docker-compose.yml#L113
with a test-container running guard. Is that worth a PR? Or do you have something else in mind?

cheers

--chris

@gmontard
Copy link
Owner

Thank you for your issue.
There is already a test coverage written using rspec, you can try it with this command:

rake test

@superbilk
Copy link
Author

hi, sorry for being unclear. that "issue" was not about he test coverage of your gem, but how you use dockrails with tests in your rails app. You could just run them locally (that works out of the box, but you miss the pros from docker) or you might spin a new container for running tests or you could run a test container continuously with guard.

Questions in general are: logging, auto-running tests on changing files. and maybe advanced: including frontend-tests.

I'd like to learn more about your setup and your recommendations.

--chris

@gmontard
Copy link
Owner

Hmm that's a fair point, to be honest I usually really on something like CircleCI so I don't really bother setting up a full test env - that said what you are proposing sounds to be a good idea. Obviously you can always run your tests locally using the same container used to run the dev env.

If you have something in mind that can work easily don't hesitate to submit a PR, I'll be glad to look at it.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants