Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion #75

Open
Idomo opened this issue Jul 10, 2018 · 1 comment
Open

Suggestion #75

Idomo opened this issue Jul 10, 2018 · 1 comment

Comments

@Idomo
Copy link

Idomo commented Jul 10, 2018

Hi @gmarm,
First thing, thanks for building this library, it's great and exactly what I was needed!

I'd like to suggest few things to change, to make the library even better:

  1. Make settings options more easier to understand
    In the beginning I thought there is no way to change it, but now I find out that I can change it via options property, it's not the most understandable way and I couldn't find any examples in the README.md or in the Example project, I think you should do something about it.

  2. Remove layer.masksToBounds = true from line 310 when indicatorViewInset is negative
    When the indicatorViewInset is negative you should get nice effect like this:
    img_ea39e9e44b0f-1
    But instead of that the indicatorViewBackground is cutting of when it's passing the BetterSegmentedControl parent view because of this line.
    I don't see any problem after comment it out so it's just unnecessary.

I'v created pull request for this: #87

Thanks,
Ido.

@Idomo Idomo changed the title Few suggestions Suggestion Jul 10, 2018
@gmarm
Copy link
Owner

gmarm commented Jul 22, 2018

  1. has been addressed by Segment protocol #78
  2. I will be having a look at this and your PR since the implementation changed a bit there.

Idomo added a commit to Idomo/BetterSegmentedControl that referenced this issue Oct 1, 2018
Set `layer.masksToBounds` to true only if `indicatorViewInset` isn't negative to achieve the effect I mentioned in gmarm#75
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants