Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Desyncronized nicklist #1263

Closed
JulienPalard opened this issue Jul 4, 2023 · 4 comments · Fixed by #1266
Closed

Desyncronized nicklist #1263

JulienPalard opened this issue Jul 4, 2023 · 4 comments · Fixed by #1266
Labels
bug

Comments

@JulienPalard
Copy link
Contributor

I've not diagnosed the root cause (sooooory) but since a few time I notice some nicklist discrepency:

  • Either it gets empty
  • Either it gets way smaller than it should (in terms of number of participants)
  • Either it's good (but I don't know, maybe it gets out of sync... ?)

Example:

Capture d’écran du 2023-07-04 21-59-52

notice there's many people in the room but only the op displayed. I bet it is displayed because he's the last one changing or connecting.

Using Firefox 114, weechat-headless 3.8-1.
This was referenced Jul 9, 2023
Merged
Open
@lorenzhs lorenzhs pinned this issue Jul 9, 2023
@lorenzhs lorenzhs added the bug label Jul 9, 2023
@lorenzhs lorenzhs reopened this Jul 12, 2023
@lorenzhs
Copy link
Member

Autoclose was a bit aggressive there 🙃

jhoneycutt added a commit to jhoneycutt/glowing-bear that referenced this issue Feb 2, 2024
@jhoneycutt
Issue glowing-bear#1263: Desynchronized nicklist
5765604 
This is fallout from glowing-bear#1244, which moved models.delNick from using a filter to
using the delete operator.

The delete operator creates a sparse array that has an empty slot for the item
that was deleted. This empty slot is iterable with some constructs, giving a
value of undefined. These unexpected undefined values in the nicklist cause
exceptions to be thrown in some situations, like when calling
models.updateNickSpeak.

To fix this, use Array.splice to remove elements from the nicklist, instead of
the delete operator.
@jhoneycutt
Copy link
Contributor

I can reproduce this by joining my bot to a channel I am in, kicking it, then rejoining it.

@jhoneycutt
Copy link
Contributor

Created PR #1274 to fix this.

lorenzhs added a commit that referenced this issue Feb 4, 2024
@lorenzhs
Merge pull request #1274 from jhoneycutt/1263-desyncronized-nicklist
e20b958 
Issue #1263: Desynchronized nicklist
@lorenzhs
Copy link
Member

lorenzhs commented Feb 4, 2024

Thank you so much! I think this will make quite a few people happy :) Merged!

@lorenzhs lorenzhs closed this as completed Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert version number increase & clean up underscore cleanup glowing-bear/glowing-bear
3 participants
@lorenzhs @JulienPalard @jhoneycutt