Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings survives restart but are not applied #1224

Open
JulienPalard opened this issue Oct 29, 2022 · 3 comments
Open

Settings survives restart but are not applied #1224

JulienPalard opened this issue Oct 29, 2022 · 3 comments

Comments

@JulienPalard
Copy link
Contributor

I do use Firefox with the "Delete cookies and site data when Firefox is closed" option.

When I open Firefox again and navigate to my GB instance or to https://latest.glowing-bear.org/, all settings are "back to the default" which is to expect, typically the "Only show buffers with unread messages" is back as its default to "False", meaning I see many many buffers with no unread messages.

BUT when I open the setting panel my old options are still here: "Only show buffers with unread messages" is checked! I have to uncheck it and check it again to see the buffers with no unread messages dissapear.

@lorenzhs
Copy link
Member

lorenzhs commented Nov 3, 2022

Not quite sure how this could happen - while we don't watch for changes in localstorage, they are reflected after a reload. And we certainly can't know about values that were deleted between browser restarts. I just tried this in Firefox - manually modifying a setting and reloading GB caused the setting to be applied.

@JulienPalard
Copy link
Contributor Author

JulienPalard commented Nov 17, 2022

I can reproduce it every time on Firefox 106, with the option "Clear history when firefox closes" configured as:

Capture d’écran du 2022-11-17 12-16-02

It looks like:

Capture.video.du.2022-11-17.12-19-53.webm

Sorry my mouse is not visible, but you can see those steps:

  • Freshly started Firefox, glowing bear displays channels with no messages
  • I open the settings panel
  • I uncheck the "Only show buffers with unread messages": nothing happen (expected).
  • I check it again, and this time channels with unread messages dissapear :)

@lorenzhs
Copy link
Member

Interesting. Wouldn't that be more of a Firefox bug then? I don't understand how this could happen, but it's also been years since I was properly familiar with the GB code base to be honest...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants