Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script "make-local" is missing #1184

Open
rain0r opened this issue Mar 31, 2021 · 4 comments
Open

Script "make-local" is missing #1184

rain0r opened this issue Mar 31, 2021 · 4 comments
Labels

Comments

@rain0r
Copy link
Contributor

rain0r commented Mar 31, 2021

The FAQ says:

run npm run make-local to download the files and apply a patch to use them instead of the CDN.

But there is no script make-local in package.json

$ npm run make-local
npm ERR! missing script: make-local
@lorenzhs
Copy link
Member

lorenzhs commented Apr 7, 2021

Yeah that bit of the FAQ is outdated since we moved to using webpack. I think we should just add a mode where the remaining dependencies are also added to the webpack config and then instead of make-local it would just be build. For the moment, npm run build gets you most of the way there.

@lorenzhs lorenzhs added the docs label Apr 7, 2021
@rain0r
Copy link
Contributor Author

rain0r commented Apr 8, 2021

Thanks, npm run build is working.

Just one more thing: Is it possible to patch the includes to be local? Like, not from google.com?

@lorenzhs
Copy link
Member

lorenzhs commented Apr 8, 2021

Google? They should be loaded from cnjs.cloudflare.com, not google.

It's not possible with the current script sadly, but we should add such a mode again. With browsers increasingly not reusing cached resources between different sites, the utility of a CDN has become very very low. Likely, we should make that the default mode. If you want to have a go, have a look at src/main.js and webpack.config.js.

@rain0r
Copy link
Contributor Author

rain0r commented Apr 11, 2021

Google? They should be loaded from cnjs.cloudflare.com, not google.

Yes, my mistake, you're right.

It's not possible with the current script sadly, but we should add such a mode again. With browsers increasingly not reusing cached resources between different sites, the utility of a CDN has become very very low. Likely, we should make that the default mode. If you want to have a go, have a look at src/main.js and webpack.config.js.

I created #1186 for that.

But I'm no webpack-expert at all so there might be a thing or two to optimize.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants