Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax MPCD restrictions on boxes #773

Open
mphoward opened this issue Sep 4, 2020 · 3 comments
Open

Relax MPCD restrictions on boxes #773

mphoward opened this issue Sep 4, 2020 · 3 comments
Assignees
Labels
mpcd MPCD component refactor Refactoring existing code

Comments

@mphoward
Copy link
Collaborator

mphoward commented Sep 4, 2020

Description

MPCD currently requires that the box size be (1) orthorhombic, (2) constant, and (3) a multiple of the MPCD cell size. Only requirement (3) is strictly necessary for the algorithm to work right, so I will check over the code to see if it makes sense to support other (e.g., deformed) boxes. This is change is not necessarily breaking but may not be the behavior expected by the user, so I will look into it for v3.

@mphoward mphoward added the task Something needs to be done. label Sep 4, 2020
@mphoward mphoward self-assigned this Sep 4, 2020
@mphoward mphoward added mpcd MPCD component refactor Refactoring existing code and removed task Something needs to be done. labels Sep 4, 2020
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale There has been no activity on this for some time. label Mar 22, 2022
@github-actions
Copy link

github-actions bot commented Apr 2, 2022

This issue has been automatically closed because it has not had recent activity.

@github-actions github-actions bot closed this as completed Apr 2, 2022
@mphoward mphoward removed the stale There has been no activity on this for some time. label Feb 2, 2024
@mphoward
Copy link
Collaborator Author

mphoward commented Feb 2, 2024

We will need to address this as part of our new work.

@mphoward mphoward reopened this Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mpcd MPCD component refactor Refactoring existing code
Projects
None yet
Development

No branches or pull requests

1 participant