Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when any semi-major axis is less than zero in Ellipsoid. #1762

Open
joaander opened this issue Apr 8, 2024 · 0 comments · May be fixed by #1785
Open

Error when any semi-major axis is less than zero in Ellipsoid. #1762

joaander opened this issue Apr 8, 2024 · 0 comments · May be fixed by #1785
Labels
task Something needs to be done.

Comments

@joaander
Copy link
Member

joaander commented Apr 8, 2024

Description

Add checks that a, b, and c are all greater than 0 in hpmc.integrate.Ellipsoid.

Motivation and context

In #1759 a user reports that ellipsoids with c=0 report no overlaps.

@joaander joaander added the task Something needs to be done. label Apr 8, 2024
@janbridley janbridley changed the title Error when any semi-major axis is non-zero in Ellipsoid. Error when any semi-major axis is less than zero in Ellipsoid. May 16, 2024
@janbridley janbridley linked a pull request May 16, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task Something needs to be done.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant