Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove implicit depletant code paths. #1651

Open
2 of 3 tasks
joaander opened this issue Nov 8, 2023 · 0 comments
Open
2 of 3 tasks

Remove implicit depletant code paths. #1651

joaander opened this issue Nov 8, 2023 · 0 comments
Labels
breaking Changes that will break API. hpmc HPMC component task Something needs to be done.

Comments

@joaander
Copy link
Member

joaander commented Nov 8, 2023 •
edited

Description

In a branch off trunk-minor:

  • Document that implicit depletants are deprecated.
  • Issue deprecation warnings when implicit depletants are used.

In a branch off trunk-major (later, close to a v5.0 release):

  • Remove all implicit depletant code paths.

Motivation and context

The implicit depletants code paths are broken (#1448). Current developers are not interested in fixing and maintaining the code.
@joaander joaander added hpmc HPMC component breaking Changes that will break API. task Something needs to be done. labels Nov 8, 2023
@joaander joaander mentioned this issue Nov 8, 2023
Open
@joaander joaander mentioned this issue Nov 20, 2023
Merged
3 tasks
@joaander joaander changed the title Deprecate implicit depletant code paths. Remove implicit depletant code paths. Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking Changes that will break API. hpmc HPMC component task Something needs to be done.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joaander