Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TBB code paths. #1650

Open
2 of 7 tasks
joaander opened this issue Nov 8, 2023 · 1 comment
Open
2 of 7 tasks

Remove TBB code paths. #1650

joaander opened this issue Nov 8, 2023 · 1 comment
Labels
breaking Changes that will break API. task Something needs to be done.

Comments

@joaander
Copy link
Member

joaander commented Nov 8, 2023

Description

In a branch off trunk minor:

  • Document that num_cpu_threads is deprecated and will be removed.
  • Issue a deprecation warning when num_cpu_threads is used.

Later (near a v5.0 release):

  • Remove the effect of num_cpu_threads and enforce num_cpu_threads == 1.
  • Remove all TBB code paths.
  • Remove all mentions of TBB in the documentation.
  • Remove all TBB CMake code.
  • Enable clang-format on files previously excluded due to TBB usage.

Motivation and context

TBB is used only in very few classes. Some of these code paths have already been disabled due to the use of removed TBB features.

I'm not aware of any users effectively deploying these code paths at this time, and I have no plans to deploy TBB to more of the HOOMD code base.

@joaander joaander added breaking Changes that will break API. task Something needs to be done. labels Nov 8, 2023
@joaander joaander mentioned this issue Nov 17, 2023
3 tasks
@joaander
Copy link
Member Author

To provide a clean upgrade path for users, 5.0 will keep the num_cpu_threads attribute but will error when the value is not 1 and will not use it. 5.0 will then issue a deprecation that num_cpu_threads will be removed in 6.0.

@joaander joaander changed the title Deprecate TBB code paths. Remove TBB code paths. Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Changes that will break API. task Something needs to be done.
Projects
None yet
Development

No branches or pull requests

1 participant