Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add global keybinding helper #69

Open
glortho opened this issue Aug 28, 2017 · 3 comments
Open

Add global keybinding helper #69

glortho opened this issue Aug 28, 2017 · 3 comments
Labels
enhancement

Comments

@glortho
Copy link
Owner

glortho commented Aug 28, 2017

See #68 for details.
This was referenced Sep 25, 2017
Closed
Closed
@sheldonrong
Copy link

hey @glortho do you mind have a quick check on PR #71 ?

I basically added a config option and if global is set to true, the key binding will be effective even the component is not focused.

@glortho
Copy link
Owner Author

glortho commented Sep 26, 2017

Sorry for the delay @sheldonrong. Thank you for doing this! I'm on crazy deadline this week but will check it out ASAP.

@glortho glortho mentioned this issue Sep 26, 2017
Open
@sheldonrong
Copy link

@glortho not a problem, send me a message when you are free to look at the PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@glortho @sheldonrong