Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any chance we could add debounce support? #44

Open
salmanm opened this issue Feb 17, 2017 · 6 comments
Open

Any chance we could add debounce support? #44

salmanm opened this issue Feb 17, 2017 · 6 comments

Comments

@salmanm
Copy link
Contributor

salmanm commented Feb 17, 2017

While using this great lib, I felt the need to have debounce support. I'd be happy to PR it if guys here think its fine to implement as part of this.

@glortho
Copy link
Owner

glortho commented Feb 21, 2017

Sure @salmanm happy to review a pr. Thank you!

@RubyEDE
Copy link

RubyEDE commented Aug 2, 2017

Any update on this?

@glortho
Copy link
Owner

glortho commented Aug 3, 2017

I haven't gotten around to this yet but happy to review a PR! Otherwise I should be able to get to it within the next couple of weeks.

@salmanm
Copy link
Contributor Author

salmanm commented Aug 3, 2017

@glortho Shall we agree upon a way to supply options?

@keydown('F', 'Y', 'I', { debounce: 200 })
myFn() {
}

Does it seem right?

@glortho
Copy link
Owner

glortho commented Oct 5, 2017

Ah sorry, I never replied to this @salmanm . Yes, I think that's the way for now.

@salmanm
Copy link
Contributor Author

salmanm commented Oct 5, 2017

No problem, been on a tight deadline just like you. I'll be more active here soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants