Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use request body instead of query string at /functions/pipeline #54

Closed
wants to merge 6 commits into from

Conversation

rAndrade360
Copy link

This PR fix #34 by passing the pipeline steps via request body instead of query string.

@ceelsoin
Copy link
Member

many users run pipelines with query string currently, changing this contract this users will break your functionally. i think this could be another way to run function pipelines, but not the only way for do this.

@ceelsoin ceelsoin self-requested a review November 10, 2023 18:51
@ceelsoin ceelsoin self-assigned this Nov 10, 2023
@ceelsoin
Copy link
Member

you can submit a new merge request considering our expectations

@ceelsoin ceelsoin closed this Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The /functions/pipeline PUT method are using QueryString in the URL to get data.
3 participants