New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom JS function not work with recent htmlwidgets version (>=1.6.3) #348
Comments
Hi, thanks for the report. Looking into it now, but I might not get back until after the weekend. |
Here's a quick workaround fix with limited testing if you install the latest dev version: 1d60ea6 When I get a chance, I'll comment in the htmlwidgets issue and possibly do a CRAN release. It seems like a complicated issue, and a better place for the fix might be either reactR or htmlwidgets. |
Thanks, glin. So Here's what I understand
Am I right? |
When I read through the Referencehttps://github.com/ramnathv/htmlwidgets/blob/master/NEWS.md?plain=1#L5-L7
|
If anyone has a chance, please test |
Nice work. library(reactable)
reactable(iris[1:5, ],
selection = "single",
onClick = JS("function(row, column, rowInfo) {
console.log('asdf');
row.toggleRowSelected();
}")
) Versions
|
Thank you very much for this post and the fix! I can confirm it fixed the issue for me, i.e., the reactable silently failing to render. |
I couldn't run an example from the documentation and was very very confused. Using the versions suggested (reactable 0.4.4, reactR 0.5.1, and htmlwidgets 1.6.3.9000) it runs fine. |
Hello guys, update So I'll close this issue. Thanks ! |
Hi, I don't think this is an issue with
reactable
, but I'm raising it just in case of further problems.Since the version of htmlwidgets was updated from 1.6.2 to 1.6.3 on November 22, my custom Javascript function in
onClick
is not working.This code selects a row when the table is clicked and outputs a log named
asdf
. (htmlwidgets 1.6.2)However, if you are using the htmlwidgets 1.6.3 version, the click will not select the row and output a log.
I think user should not using 1.6.3 version until this problem solved.
Thanks.
The text was updated successfully, but these errors were encountered: