Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependencies::is_same_requirements is incorrect #3110

Closed
u9g opened this issue May 8, 2024 · 3 comments
Closed

dependencies::is_same_requirements is incorrect #3110

u9g opened this issue May 8, 2024 · 3 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Contributions encouraged priority:high

Comments

@u9g
Copy link

u9g commented May 8, 2024

dependencies::is_same_requirements is incorrect when a requirement is made using an absolute path in the gleam.toml

this is what the left and right look like after going through the maybe canonicalize operations:

INFO download_deps: left: \\?\C:\Users\---\Documents\code\5-7-24\stdlib right: C:\Users\---\Documents\code\5-7-24\stdlib

The solution is to just unconditionally canonicalize both paths.

@u9g u9g added the bug Something isn't working label May 8, 2024
@lpil
Copy link
Member

lpil commented May 9, 2024

Ah! Thank you. Good detective work

@lpil lpil added help wanted Contributions encouraged good first issue Good for newcomers priority:high labels May 9, 2024
@Francisco-Montanez
Copy link
Contributor

I can take this if not done

Francisco-Montanez added a commit to Francisco-Montanez/gleam that referenced this issue May 11, 2024
Francisco-Montanez added a commit to Francisco-Montanez/gleam that referenced this issue May 11, 2024
@lpil
Copy link
Member

lpil commented May 13, 2024

Thank you @Francisco-Montanez !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Contributions encouraged priority:high
Projects
None yet
Development

No branches or pull requests

3 participants