Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redund overloads from signal connect method #92

Open
JumpLink opened this issue Sep 26, 2022 · 1 comment
Open

Redund overloads from signal connect method #92

JumpLink opened this issue Sep 26, 2022 · 1 comment

Comments

@JumpLink
Copy link
Collaborator

This happens since #91

grafik

@HeavenVolkoff
Copy link
Contributor

HeavenVolkoff commented Sep 27, 2022

This issue completely slipped though my tests, thanks for finding it. I already came up with a solution that seems to be working fine, but this time I am going through the diffs of all definitions generated by yarn run build:types:all to ensure nothing odd comes up. Only downside is that generation got slightly slower, but not by much:

Before:
IMG_20220927_041823_416.jpg

After:
IMG_20220927_041826_311.jpg

Also, while checking the diffs, some other cases of repeatead method definitions came up. It seems the conflict resolution for methods was adding clashing definitions as overloads even when they were the same. I am going to fix that too. There were some other cases, but I couldn't pinpoint the origin for their occurrence, however my current solution will take care of them as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants