Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing promisified overloads #171

Open
JumpLink opened this issue May 5, 2024 · 3 comments
Open

Missing promisified overloads #171

JumpLink opened this issue May 5, 2024 · 3 comments

Comments

@JumpLink
Copy link
Collaborator

JumpLink commented May 5, 2024

@ewlsh Some promisified methods are missing, for example for Gio.read_async + Gio.read_finish or Gio.File.load_contents_async + Gio.File.load_contents_finish

@ewlsh
Copy link
Collaborator

ewlsh commented May 14, 2024

I'm looking at what happened here, should have a fix in the next few weeks.

@swsnr
Copy link
Contributor

swsnr commented May 17, 2024

I'm upgrading a GNOME extension to ts-for-gir 4.0.0 types, and noticed missing promisified overloads as well:

  • Soup.Session.send_async
  • Soup.Session.send_and_read_async
  • Gio.File.delete_async

Is this the same issue, or should I rather open a new one?

@JumpLink
Copy link
Collaborator Author

JumpLink commented May 17, 2024

@swsnr I think this will be the same problem, so it will be correct here.

@ewlsh In v3 I just checked if there are methods with the same prefix and ending with _async and the other with _finish, but that might not be so clean either, especially since there are some cases where this convention is not followed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants