Focus getting trapped in GitPitch menu

[missmatsuko]

When I try to tab through the slide deck online (e.g. https://gitpitch.com/gitpitch/kitchen-sink), it goes into the GitPitch menu even though it's not open.

[gitpitch]

That's ok I think, the tab key is not a supported navigation control within slides - use the SPACE key or the arrow keys to navigate instead. The full set of support keyboard controls are detailed in the doc here. Or simply hit the ? key while viewing a live presentation.

[missmatsuko]

What if there's links in slide content? Keyboard users may use tab to navigate to the next link and lose their keyboard focus in the menu links when they expected it to go to a link in the slide content.

Especially considering someone who is not familiar with GitPitch and is provided a GitPitch slide deck, they may not notice the keyboard controls right away.

[gitpitch]

What if there's links in slide content? Keyboard users...

Then there could indeed be a problem. Thanks for reporting. I'll look into it when time permits.

[becka11y]

So, this should be relatively easy to fix. When the menu is not visible on the screen, set the
< nav class="slide-menu slide-menu--left active"> to display:none.This will prevent the tab stops from being active and the screen readers will not speak it. This is really important for accessibility. The current situation makes it fairly unusable for someone using only a keyboard.

The screen reader will speak the text contents of each slide when it becomes visible. But if the user wants to explore any images on the page she needs to be able to navigate the page via the keyboard.

[becka11y]

Okay, perhaps not so easy to fix. I added display:none via the developer tools and was still seeing focus getting trapped in the menu area. But, that is a start. The button to toggle the menu also needs a label and it should be a toggle button rather than an anchor.

[gitpitch]

Support for the side menu that provides access to the table-of-contents for a GitPitch slide decks has changed. I believe the issue reported on this thread is resolved as a consequence of these changes but I'd like to be sure of that before closing out this issue thread. Can you please test one of your own decks and let me know what you see. Thanks, David.

[missmatsuko]

I never ended up making a deck. Is the kitchen sink one updated with these changes? I notice in that one that all the content links are focusable even when they aren't visible. It seems like focus doesn't go through all the menu items anymore, but I can't get focus to get on the menu button to open it.

[gitpitch]

Thanks for the quick feedback. I'll take a look at the deck you mentioned as a test case and see what needs to be done to prevent non-visible links from stealing tab focus.