Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements drag and drop upload of image in every markdown-area #7011

Merged
merged 1 commit into from May 23, 2014

Conversation

erbunao
Copy link
Contributor

@erbunao erbunao commented May 23, 2014

creating issues, notes, wikis, and merge requests.

Samples:

Issues:
issue_new

issue_new_result

Notes:
notes_new

Wiki:
wiki_new

wiki_new_result

Merge Request:
merge_request_success_out

merge_request_result

merge_request_error

Right now, we're writing the spec for this. Again, feedbacks are needed.

Note:
This is a follow-up PR to #6962. We just entertained the idea to generalize this feature to have a more unified UI/UX.

describe ProjectsController do
let(:project) { create(:project) }
let(:user) { create(:user) }
let(:png) { fixture_file_upload(Rails.root + 'spec/fixtures/dk.png', 'image/png') }

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is too long. [89/80]

@dzaporozhets
Copy link
Member

I tried it and it works great! Thank for such awesome contribution!

dzaporozhets added a commit that referenced this pull request May 23, 2014
Implements drag and drop upload of image in every markdown-area
@dzaporozhets dzaporozhets merged commit fc86165 into gitlabhq:master May 23, 2014
@dzaporozhets
Copy link
Member

@erbunao can you give me your full name for CHANGELOG?

@maxlazio
Copy link
Member

@erbunao Very nice 👍

@JobV
Copy link
Contributor

JobV commented May 23, 2014

@erbunao Super cool, awesome PR.

@kemenaran
Copy link
Contributor

@erbunao thanks for this 👍

@jvanbaarsen
Copy link
Contributor

Awesome feature 👍

@mikedugan
Copy link

@erbunao nice work!

@marzapower
Copy link

👍

@forki
Copy link

forki commented May 23, 2014

😍

I'd also like to see a "paste from clipboard"

@drleviste
Copy link

Great job guys!

@kimmy
Copy link

kimmy commented May 23, 2014

Congrats @erbunao @nmcalabroso!

@jvanbaarsen
Copy link
Contributor

@randx Can it be that because of this MR the tests are currently not green? If so, is anyone already working on them?

@dzaporozhets
Copy link
Member

@jvanbaarsen i think so too. @maxlazio working on this

@jvanbaarsen
Copy link
Contributor

@randx Ok thanks, I'll wait for @maxlazio in that case :-) Otherwise we are doing double work :)

@nmcalabroso
Copy link

@forki, we are still working for that feature. Right now for the clipboard, some images seems to be corrupted upon upload while some are not. Maybe next week we can make an update.:) @erbunao

@forki
Copy link

forki commented May 23, 2014

sweet!

@padi
Copy link

padi commented May 24, 2014

@erbunao @nmcalabroso good job! :) 👍

@ianpogi5
Copy link

@erbunao @nmcalabroso salamat!

@erbunao
Copy link
Contributor Author

erbunao commented May 24, 2014

@randx we are Earle Randolph Bunao and Neil Francis Calabroso. Thank you for merging! Hope GitLab likes it. :)

@jimmybrancaccio
Copy link

This looks awesome! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet