New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements drag and drop upload of image in every markdown-area #7011
Conversation
describe ProjectsController do | ||
let(:project) { create(:project) } | ||
let(:user) { create(:user) } | ||
let(:png) { fixture_file_upload(Rails.root + 'spec/fixtures/dk.png', 'image/png') } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line is too long. [89/80]
I tried it and it works great! Thank for such awesome contribution! |
Implements drag and drop upload of image in every markdown-area
@erbunao can you give me your full name for CHANGELOG? |
@erbunao Very nice 👍 |
@erbunao Super cool, awesome PR. |
@erbunao thanks for this 👍 |
Awesome feature 👍 |
@erbunao nice work! |
👍 |
😍 I'd also like to see a "paste from clipboard" |
Great job guys! |
Congrats @erbunao @nmcalabroso! |
@randx Can it be that because of this MR the tests are currently not green? If so, is anyone already working on them? |
@jvanbaarsen i think so too. @maxlazio working on this |
sweet! |
@erbunao @nmcalabroso good job! :) 👍 |
@erbunao @nmcalabroso salamat! |
@randx we are Earle Randolph Bunao and Neil Francis Calabroso. Thank you for merging! Hope GitLab likes it. :) |
This looks awesome! 👍 |
creating issues, notes, wikis, and merge requests.
Samples:
Issues:
Notes:
Wiki:
Merge Request:
Right now, we're writing the spec for this. Again, feedbacks are needed.
Note:
This is a follow-up PR to #6962. We just entertained the idea to generalize this feature to have a more unified UI/UX.