Add support for Custom Model to OpenAI settings #3225
+39
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have not made any changes to the CHANGELOG or README, yet. I am happy to do so after we have agreed on the approach in this PR. I have a different version of this PR that adds a CustomProvider class, but after some thought, it might not be necessary since the custom URL for OpenAI is very close to working with any server (not just Azure). |
shopdrop1
approved these changes
Apr 29, 2024
|
@SpaceMerlin33 Do you mind taking a look at this? |
|
@trevor-polidore Let me know what you think. |
|
@cmgriffing There have been significant changes to the AI providers, can you adapt this to the new model? |
eamodio
reviewed
May 18, 2024
| "order": 102 | ||
| }, | ||
| "gitlens.ai.experimental.openai.customModel": { | ||
| "type": [ |
There was a problem hiding this comment.
Do we need another setting for the custom model? Can't we just use the model setting above?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new setting to VSCode in the AI section for a custom model name to be sent to an OpenAI-compatible API. A larger PR was in the works until I realized that the existing custom URL functionality would work.
Closes #3223
Checklist
Fixes $XXX -orCloses #XXX -prefix to auto-close the issue that your PR addresses