Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let's document the gate decorator! #2634

Open
sadasant opened this issue Apr 14, 2023 · 0 comments · May be fixed by #2635
Open

Let's document the gate decorator! #2634

sadasant opened this issue Apr 14, 2023 · 0 comments · May be fixed by #2635
Labels
feature New feature or request triage Needs to be looked at

Comments

@sadasant
Copy link
Contributor

While reading the codebase, I was briefly confused by the gate decorator.

For a second, I thought gate to what?

I believe some comments would help!
@sadasant sadasant added feature New feature or request triage Needs to be looked at labels Apr 14, 2023
@sadasant sadasant linked a pull request Apr 14, 2023 that will close this issue
Open
7 tasks
sadasant added a commit to sadasant/vscode-gitlens that referenced this issue Apr 14, 2023
@sadasant
Fixes gitkraken#2634 - Comments gate.ts
f01c3fb 
While reading the codebase, I was briefly confused by the gate decorator.
Here, I've added comments to the decorator to make it easier to understand.
I'm hoping these comments will help others dive through the codebase as well 🙂
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request triage Needs to be looked at
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Commenting gate.ts sadasant/vscode-gitlens
1 participant
@sadasant