Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler error. #705

Closed
andre-caldas opened this issue May 8, 2024 · 1 comment · May be fixed by #710
Closed

Compiler error. #705

andre-caldas opened this issue May 8, 2024 · 1 comment · May be fixed by #710

Comments

@andre-caldas
Copy link

I am getting that dim is a function, not a short_t variable. It should probably be dim(). Or m_dim...

short_t parDim() const { return dim; }

I might be saying something silly, I've just met G+Smo a few hours ago. :-)

I have changed mine to dim() and it compiles, now. Looks like some sort of regression, but the sources have not been modified for a long time.

@hverhelst
Copy link
Member

Hi @andre-caldas ,
Thanks for finding that one! I agree with you. Changing it to dim() or m_dim seems to be the same (according to gsBoxTopology so either of the two is a good fix.
Could you make a PR closing this issue?
Thanks!

andre-caldas added a commit to andre-caldas/gismo that referenced this issue May 15, 2024
For some reason we are returning a method's name instead of
calling it.

Fixes:
gismo#705
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants