New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow-up from "Minor code optimisation #567" #577

Open

64J0 opened this issue Feb 23, 2024 · 0 comments

Labels

Member

64J0 commented Feb 23, 2024 •

edited

Description:

@Thorium suggested:

Another modification to consider, would be adding [<Struct>] attribute to Giraffe's minor enum-types like HttpVerb, MatchMode, Precondition, CacheDirective and RangeBoundary. But if there are proper performance tests somewhere, could be first tested if they'd have any effect or not. But I guess that goes around questions like should some Option values changed to ValueOption values.

Reference to the PR: #567

64J0 added the help wanted label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment