Adds support for named networks #43
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow to define `-n <network_name>` to create the VM attached to that network
giovtorres
requested changes
Oct 21, 2019
There was a problem hiding this comment.
Hi @bkmeneguello. Thank you for your contribution! This looks great. A couple comments below. Also, could you update the README with the newly added option.
giovtorres
reviewed
Oct 21, 2019
Comment on lines
+621
to
+630
| if [ -n "${NETWORK_NAME}" ] | ||
| then | ||
| NETWORK_PARAMS="$(param network ${NETWORK_NAME})" | ||
| elif [ -n "${BRIDGE}" ] | ||
| then | ||
| NETWORK_PARAMS="$(param bridge ${BRIDGE})" | ||
| else | ||
| NETWORK_PARAMS="none" | ||
| fi | ||
|
|
giovtorres
reviewed
Oct 22, 2019
| @@ -691,6 +702,10 @@ _EOF_ | |||
| outputn "Cleaning up cloud-init files" | |||
| rm -f $USER_DATA $META_DATA $CI_ISO && ok | |||
|
|
|||
| if [ -n "${NETWORK_NAME}" ]; then | |||
| BRIDGE=$(virsh net-dumpxml "${NETWORK_NAME}" | awk -F\' '/bridge/ {print $2}') | |||
There was a problem hiding this comment.
I'm a bit nervous about splitting on the first single quote. What if name= is not first in the bridge tag?
What about something like: virsh net-info "${NETWORK_NAME}" | awk -F':' '/Bridge/ {print $2}' | tr -d ' ' ?
Thoughts?
|
Are you still working on this PR? |
imgrant
added a commit
to imgrant/kvm-install-vm
that referenced
this pull request
Nov 3, 2020
Following suggestion from 22-Oct-2019 in stale PR giovtorres#43 to upstream fork
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to define
-n <network_name>to create the VM attached to that networkProbably fixes #16