Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate remove Axios and use fetch api when it becomes stable #381

Open
giggio opened this issue Sep 19, 2022 · 4 comments
Open

Investigate remove Axios and use fetch api when it becomes stable #381

giggio opened this issue Sep 19, 2022 · 4 comments

Comments

@giggio
Copy link
Owner

giggio commented Sep 19, 2022

Fetch api is only available in Node 18+, but experimentally, and at the time of this writing, it is still experimental in Node 20.

Investigate if the fetch api will be able to do everything Axios does (proxy support etc).
Fetch api is also not yet stable on Node 20, if it is not stabilized we will need to wait until it is.

See the https://github.com/giggio/node-chromedriver/tree/fetch_api branch for an update on the update.js script (https://github.com/giggio/node-chromedriver/blob/fetch_api/update.js).

@giggio giggio changed the title Investigate remove Axios and use fetch api when Node 16 is out of support Investigate remove Axios and use fetch api when it becomes stable May 2, 2023
@christian-bromann
Copy link

Fetch has shipped as stable in v18 onwards 😉

@giggio
Copy link
Owner Author

giggio commented Jun 15, 2023

@christian-bromann docs still mention it as experimental.

@andrewiggins
Copy link

Fetch is documented as stable in Node v21! So the next LTS to have it will be v22. +1 to do this when the time is right :)

@giggio
Copy link
Owner Author

giggio commented Nov 1, 2023

Awesome! We'll need to wait until Node.js 20 is out of support, until April 2026.
https://nodejs.org/en/about/previous-releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants