Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect_chromedriver_version=true getting incorrect version if dev/canary/beta installed #364

Open
kylemorelock opened this issue May 19, 2022 · 2 comments

Comments

@kylemorelock
Copy link

Running this awesome util (thanks for publishing) and due to some recent changes, the detect_chromedriver_version=true option is causing a failure when downloading chromedriver. The util is detecting version 104.0.5071.0 and since there is no published chromedriver version, the download fails with a 404.

Where is the util reading the chrome version from? Perhaps an improvement would be to read from a different, channel specific, location?

@giggio
Copy link
Owner

giggio commented Jun 6, 2022

Yes, it'll probably fail. It is coming from https://github.com/testimio/chrome-version/.
I checked, they don't have an option to select the channel at the moment. You could open an issue there, and once it is implemented we could update our code to take it into consideration.
Or maybe search for another library, I'm open to that as well. PRs are welcome.

@kylemorelock
Copy link
Author

Thanks. Issue opened there. testimio/chrome-version#13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants