Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to provide custom writeable stream for logs #313

Open
christian-bromann opened this issue May 18, 2021 · 3 comments
Open

Allow to provide custom writeable stream for logs #313

christian-bromann opened this issue May 18, 2021 · 3 comments

Comments

@christian-bromann
Copy link

It would be great if users could pass in a custom writeable stream to direct Chromedriver logs to a dedicated location.

@giggio
Copy link
Owner

giggio commented May 18, 2021

Chromedriver is a binary executable not a Node.js script, and this package does not control it, it only allows you to install it and start the process.
I'm not sure this idea is feasible. How do you see it being implemented?

@christian-bromann
Copy link
Author

Sorry for not being clear enough. Currently starting the Chromedriver process programatically only allows to pipe the stdout/stderr into the process stdout/stderr. It would be great if some option arguments could be passed in that would allow to control this better, e.g. make this piping optional, create spawn process first, then wait for for the port to open so we can attach to the process stdout in between. I've been successfully working around this.

@giggio
Copy link
Owner

giggio commented May 20, 2021

Ok, that makes sense. A PR is welcome but it must not break the existing api.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants