Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UPDATE] Allow additional Ad Blocker filters #22

Closed
maverick74 opened this issue Apr 2, 2018 · 20 comments · Fixed by #527 or #1354
Closed

[UPDATE] Allow additional Ad Blocker filters #22

maverick74 opened this issue Apr 2, 2018 · 20 comments · Fixed by #527 or #1354
Assignees
Labels
Ad-Blocking Issues releated to Ad Blocking Feature Request

Comments

@maverick74
Copy link

maverick74 commented Apr 2, 2018

Update from Ghostery:

We actively work to deliver this functionality to Ghostery 10. Expect custom filter editor ready in June when Ghostery 10 will be launched to Chrome store.

Original issue:

Not sure how this would work, but i think it would be good to allow the inclusion of other Filters beside the traditional EasyList.

@trickpattyFH20
Copy link
Contributor

trickpattyFH20 commented Apr 3, 2018

@maverick74 We have documentation on the tracker db here If you would like to integrate other filter lists with Ghostery you could create a db following that schema and make a build of Ghostery with the new db

@christophertino
Copy link
Contributor

This would need to be implemented in the ad blocker.

@zhonghao-cliqz

@maverick74
Copy link
Author

@trickpattyFH20 But, from what i understand, that would mean i would have "my own Ghostery", since i would have to make a build of it.
(or did i misunderstood your idea?)

My idea was to have this feature in the upstream real Ghostery, allowing users to choose lists they would like to use easily

@christophertino
Copy link
Contributor

@maverick74 This is definitely something we will consider as we build out features for the Ad Blocker. Right now it's just an on/off state. You can see the lists we're implementing here. I agree it would be nice to have some granularity and choice with the filter lists.

@maverick74
Copy link
Author

@christophertino great!

It's not that i want to disable any. In fact, my intention is to be able to enable more lists since i occasionally see one or two ads here and there that are blocked on ublock, for example.

@remusao
Copy link
Contributor

remusao commented Sep 25, 2018

Hi @maverick74,

If you see some ads, would you maybe consider sharing the websites with us? That would be of great help to either make sure it's not a bug, or consider adding extra list to broaden our coverage.

Thank you so much!

@maverick74
Copy link
Author

Hi @remusao ,

I'm trying Ghostery with full block / block all in order to compare it with other blockers.

I'll keep a list any webpage URL that has ads and will share them here... if i get any :)

(with this settings, so far, i'm pretty happy)

@maverick74
Copy link
Author

maverick74 commented May 21, 2019

@christophertino will there be any beta of v8.4 for us to test?

( oh, and an update on whether or not i've see any ads: since i "blocked all" - as i mentioned above - i'm pretty happy with it! But i still think that would be nice for users to be able to manually add or choose other block lists )

@remusao
Copy link
Contributor

remusao commented May 23, 2019

@maverick74 It's true that giving the possibility to select custom lists would add some value for some users. On the other hand, Ghostery already gives quite some flexibility in terms of which trackers to block, etc. And in many ways this mechanism is more granular than selecting subscriptions for the adblocker.

Instead, there is another way with which we're playing right now: there could be a switch to ask the adblocker to be more "strict" and also block some tracking as well as ads (but again, this is already something done by Ghostery so the impact would not be as visible as one might think). This would effectively enable some extra subscriptions such as Easyprivacy. On the other hand, we would make sure that the set of rules used play well with the Ghostery experience and limits breakage as much as possible. We really want a "work out of the box" experience for the users and the default settings should work for most people.

@maverick74
Copy link
Author

@remusao So there is no plans to allow [manually] adding extra filters, for the time being?

analyzing it, adding the possibility of customization (beside blocking capabilities) might give the "psychological" impact on users' mind that they are free to customize / add any extra rules and so it may also help in spreading the product.

On the other way, this would probably only affect "power users" - that may influence others, but that are still are a small group - and this brings in your point that the most important is a great "out of the box" experience.

All in all, thanks for sharing the "other way with which you're playing right now". It seems a good improvement about privacy. Users these days tend to like "switch" :)

@maverick74
Copy link
Author

update: I've found an example where ublock (with all blocks/lists enabled) is blocking side ads that ghostery is not:
https://www.thewatchcartoononline.tv/

@remusao
Copy link
Contributor

remusao commented May 23, 2019

@maverick74 Thanks for the report, I can indeed reproduce this issue but it seems to be fixed in the most recent version of the adblocker (tested in latest browser-core and same default subscriptions). So it will definitely be fixed in next release and that does not appear to be an issue with the lists.

@remusao remusao added the Ad-Blocking Issues releated to Ad Blocking label May 27, 2019
@remusao remusao self-assigned this May 27, 2019
@christophertino
Copy link
Contributor

@maverick74 related to this topic, we'll be adding the ability to create custom tracker patterns in one of our next releases (~v8.4.5). It's not the same as ad blocker filter lists but it will allow you to block additional URL patterns not currently in the Ghostery DB.

@maverick74
Copy link
Author

@christophertino It was not exactly what i was hopping for, but will wait and see how it works. :)

Is there any particular reason to discard ad blocker filter lists and use URL patterns instead?

@christophertino
Copy link
Contributor

We discussed internally and decided that for the first iteration of this feature we'll concentrate on tracker pattern URLs, since that has always been the primary focus of Ghostery. It's also been a frequent request from people who use Ghostery for web-dev and site-audits. But that's not to say we won't also look at custom filter lists for the Ad-Blocker. I've added that feature as a Discovery option for this ticket.

@ghost
Copy link

ghost commented Aug 26, 2019

Ghostery is really one step away from being the main extension to be downloaded for privacy by not having the functionality to add more filters. Some of the most important use cases include language specific filters (both AdGuard and Easylist have them) and annoyance filters. I understand this would require resources to be able to support different syntax (see AdGuard filters) but in the end this is the one thing that keeps me and many that I know from using Ghostery

@remusao
Copy link
Contributor

remusao commented Aug 31, 2019

Hi @grgnday, @maverick74,

Thanks for the great feedback. I work on Ghostery's adblocker and would like to give a bit of insight about supporting extra lists. We've been discussing this topic multiple times internally in the past and there are a few important things to consider:

  • There is technically nothing that prevents us from enabling more lists in the extension (in fact, syntax from Easylist, uBlock Origin and most of Adguard's is already supported). What needs to be considered though, is how it fits into the Ghostery experience and what value it would add for users (e.g.: more privacy, more comfort, etc.).
  • Ghostery already enables language-specific filters automatically based on your browsing habits. When the adblocker starts, it checks locally the language of the sites you visit most (it goes without saying that no data ever leaves your browser), then can decide to enable extra filters based on this information. For example if you visit German websites regularly, then Easylist Germany will be enabled transparently to customize adblocking. We always try to provide the best settings out of the box so that users are as safe as possible, even without the need for manual customization. Automatically enabling language specific lists is one way we achieve this.
  • In the light of the previous point, it would be interesting to experiment with extra options such as "enable anti-annoyance mode". If such an option were to be provided, would it alleviate the need to add custom lists manually? Again, more options does not necessarily means better privacy protection or better adblocking; which is why we carefully consider the implications and benefits of adding new features in Ghostery.
  • Last but not least, not allowing arbitrary lists in Ghostery at the moment allows us to make sure features behave optimally and do not conflict with each other. For example, the blocking lists used by default in the adblocker are selected and optimized so that they play well with our AI anti-tracking technology. We are also able to pre-bundle them and ship/update them very efficiently to/in the client instead of downloading huge assets which need to be parsed in the client and would result in higher data and CPU usage [1].

Thanks again for your feedback, we will definitely keep the door open for more customization in the future. But it's important to understand that sometimes less is more and that adding features does not necessarily equates with better protection.

Looking forward to read more feedback from the community on this!

Best,
Rémi


[1] in a recent performance study we showed how Ghostery's adblocker can be initialized two to three orders of magnitude faster as compared to other popular adblockers using these techniques (it also uses much less memory for the same number of blocking rules).

@ghost
Copy link

ghost commented Aug 31, 2019

I must admit. I should have checked if Ghostery would enable language specific filters before commenting something that you have probably seen multiple times now :) and I really want to thank you again for answering with such an informative manner. One better informed suggestion then, maybe also consider enabling AdGuard’s language specific filters too if not already. They are just like easylist’s filters but they offer filters for more languages such as Turkish, Russian etc. and they should be pretty optimized.

@maverick74
Copy link
Author

I was also not aware of this "automatic list enabler" feature. That is very nice!!! Maybe that could be a "selling point":

Ghostery Automatically manages your adblocking lists based on your usage so that you don't have to do it yourself.

As for the "enable anti-annoyance mode", being a fan of "the more options, the better" philosophy I would welcome the option, however... I have came to learn - the hard way - that to most people too many options could be a problem.

(eg: i was totally anti-GNOME, for example, and totally pro-KDE! But no! Gnome guys are really right in many things. They're just not "MY" desktop, but for most people, KDE Plasma remains totally unexplored and to some even confusing... So, I get the point of too many options may not be as good As it sounds...)

Anyway, thanks for the explanation. That's one thing I really like about you guys - you do reply your users :)

@christophertino christophertino changed the title More Filters Allow additional Ad Blocker filters Sep 4, 2019
@christophertino christophertino pinned this issue Sep 4, 2019
@ghost
Copy link

ghost commented Sep 8, 2019

My suggestion would be to use AdGuard Language filters anywhere EasyList is not available as a fallback filter so that more languages would be covered by Ghostery.

@benstrumeyer benstrumeyer unpinned this issue Sep 17, 2019
@christophertino christophertino pinned this issue Oct 24, 2019
@benstrumeyer benstrumeyer unpinned this issue Oct 25, 2019
@christophertino christophertino pinned this issue Feb 3, 2020
@christophertino christophertino linked a pull request Apr 17, 2020 that will close this issue
@chrmod chrmod changed the title Allow additional Ad Blocker filters [UPDATE] Allow additional Ad Blocker filters Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ad-Blocking Issues releated to Ad Blocking Feature Request
Projects
None yet
6 participants
@chrmod @remusao @christophertino @trickpattyFH20 @maverick74 and others