Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge with gdoc2adoc project #25

Open
ggrossetie opened this issue Aug 18, 2016 · 5 comments
Open

Merge with gdoc2adoc project #25

ggrossetie opened this issue Aug 18, 2016 · 5 comments

Comments

@ggrossetie
Copy link
Owner

ggrossetie commented Aug 18, 2016

The following project has the same goal and supports a wide range of features.

I think it makes sense to merge the two projects.

https://github.com/maxandersen/gdoc2adoc

/cc @maxandersen

@briandominick
Copy link
Contributor

I haven't had a chance to look at the other project. I'll get to it this weekend 💯

@maxandersen
Copy link

FYI - I actually did my best to start from this project but when I started I did not know enough about google doc api to fix the bugs I saw - now that I completed my work (based of a markdown variation) I got what I so far can see does the conversion better (full support for tables, nested formatting and most important support for images).

The only feature I did not replicate was the "select part of text and convert", but we can look at how to bring that back while still have the image feature supported.

If you find something missing let me know.

I was actually thinking if we shuold move this work to asciidoctor org ? /cc @mojavelinux

@mojavelinux
Copy link

mojavelinux commented Aug 21, 2016

This is definitely a tool I'd like to see in the Asciidoctor organization. I'm not sure about the name (gdoc2adoc), though. While I see that "gdoc2*" or "gdocs2*" is a popular naming scheme, I wonder if it will be easy enough to find. One solution is to fold the new code into the current repository so we can reuse the name asciidoc-googledocs-addoc. I'm open to suggestions. Just keep in mind the goal is just to make it easy to discover.

@ggrossetie
Copy link
Owner Author

@maxandersen I did a quick test today and your extension is working great. However I found a few issues with the formatting. I'm using the following document to test the conversion: https://docs.google.com/document/d/1gaxFyGqutLKSmWoznxtonRCWNRYwd_Gl0aNVBKU9p4U

On left gdoc2adoc and on right the AsciiDoc Processor Addon:

compare

  • Extra space between letters when a single letter is bold (second line)
  • Extra line break on paragraph (between line 4 and 5)
  • Underline is not supported inside table
  • Extra ":toc: macro" in the last table cell ??
  • Monospaced block is not rendered as source block (see "Hello World" in Java)

compare2

  • Extra ":toc: macro" in the content

How do you want to proceed with this issue ?
I think the add-on should be available in the Chrome Webstore. Do you have a Chrome Webstore account ? Did you passed the Google review ?

@maxandersen
Copy link

Thanks for looking!

Extra space between letters when a single letter is bold (second line)

this is caused by the formatting code not looking "forward" - should probably look at taking what is done in this project to get it better. Related to maxandersen/gdoc2adoc#6

Extra line break on paragraph (between line 4 and 5)

Did not look - but yes, annoying ;/ maxandersen/gdoc2adoc#15

Underline is not supported inside table

underline was not even covered at all - i fixed that now ;)

Extra ":toc: macro" in the last table cell ??

yeah, I found this too. my logic used to trigger top level macro has a bug. need to find another way to handle it. maxandersen/gdoc2adoc#16

Monospaced block is not rendered as source block (see "Hello World" in Java)

This is due to font detection only looking at courier new - have extended it but still not handling multiline the best. maxandersen/gdoc2adoc#17

How do you want to proceed with this issue ?

I'll try fix some over the weekend.

I think the add-on should be available in the Chrome Webstore. Do you have a Chrome Webstore account ? Did you passed the Google review ?

I tried submitting it but it always fails with an error - no explanation why :/

it works fine when I install it "locally" so not sure why it fails on simply submitting it for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants