Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shadow example fix and crevice re-export #1090

Closed
wants to merge 3 commits into from
Closed

shadow example fix and crevice re-export #1090

wants to merge 3 commits into from

Conversation

PSteinhaus
Copy link
Member

fixed shadows example;
re-exported crevice as a whole for the AsStd140 macro to work outside of ggez;

The thing is: Whatever I do, I still can't use the AsStd140 macro outside of ggez (i.e. when creating a test project and depending on ggez, but not crevice directly). Whenever I try I only get this:

error[E0433]: failed to resolve: could not find `crevice` in the list of imported crates
  --> src\main.rs:13:10
   |
13 | #[derive(AsStd140)]
   |          ^^^^^^^^ could not find `crevice` in the list of imported crates
   |
   = note: this error originates in the derive macro `AsStd140` (in Nightly builds, run with -Z macro-backtrace for more info)

no matter if I use ggez::graphics::crevice or not

@PSteinhaus
fixed shadows example;
2f7f56c 
re-exported crevice as a whole for the AsStd140 to work outside of ggez;
adapted examples to use this new export;
@PSteinhaus
actually re-exported crevice...
263e4a7
@PSteinhaus
cleanup
8faa8f0
This was linked to issues Aug 31, 2022
crevice import required? #1084
Open
Unsolved merge conflict in shadow example #1089
Closed
@nobbele nobbele mentioned this pull request Sep 18, 2022
Merged
@nobbele
Copy link
Member

nobbele commented Sep 18, 2022

Attempted the crevice re-export, couldn't find any way to do it either

@PSteinhaus
Copy link
Member Author

Then I'd say we simply don't re-export crevice for now and instead put comments into the example telling that you have to depend on the same version of it which ggez is using.

@nobbele nobbele closed this Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
*HELP WANTED*
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

crevice import required? Unsolved merge conflict in shadow example
2 participants
@PSteinhaus @nobbele