Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Post-callbacks #30

Open
Spotnyk opened this issue Jun 20, 2011 · 3 comments
Open

Feature: Post-callbacks #30

Spotnyk opened this issue Jun 20, 2011 · 3 comments
Assignees
Labels

Comments

@Spotnyk
Copy link

Spotnyk commented Jun 20, 2011

You thought about adding optional callback support to helpers which can (in most cases) be detected complete? Such as channelMode, join, etc.

With channelMode, in most cases you will see the MODE bounced back to the channel, so you could fire a callback. Or you know when the server had joined you to a channel, so a callback could be fired there.

Granted this can be done above the framework, but if it were a part it could make working with it much easier (as half my slowdowns have been dealing with knowing when something completes).

Just a thought.

@gf3
Copy link
Owner

gf3 commented Jun 20, 2011

I like it! I'll have to comb through the spec, and see what kinds of things give me "finished" message. Some might be tricky, because the desired data is not always returned on the same message (e.g. first, multiple, or last).

@ghost ghost assigned gf3 Jun 20, 2011
@Spotnyk
Copy link
Author

Spotnyk commented Jun 20, 2011

Understood.

In any case, you can be clear in the docs that callbacks should be tested before relying on them.

Or, depending on how much commitment to this project you're planing, could start a "supported server daemon" list. :)

Completely off topic, with the research this project has required already; have you toyed with the thought of rolling a server yourself? :P

@ghost
Copy link

ghost commented Aug 20, 2012

In the nlogax/experimental branch, I have callbacks for join and… maybe that’s it.
But I want to add more, in fact I just commented on another issue requesting some help in identifying which commands would benefit from callbacks.
I realize you commented a year ago, but if you feel like it, picking those out would be of great help (I have become somewhat code-blind).
Also in that branch, there is a very crummy “server” used for testing, would be awesome to develop it into an actual server; both for making tests much better and for having a complete IRC package.

Edit: the branch started out as me hacking around, but @gf3 liked the direction it was going in and we decided it should be the next major version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants