Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RUSTSEC-2024-0003] [RUSTSEC-2024-0019] and [RUSTSEC-2020-0043] (among many others) #2465

Open
Pi-Cla opened this issue Mar 24, 2024 · 4 comments

Comments

@Pi-Cla
Copy link

Pi-Cla commented Mar 24, 2024

Bug Report

Currently this project is depending on dependencies which are vulnerable to:
RUSTSEC-2024-0019,
RUSTSEC-2024-0003,
RUSTSEC-2020-0043

In addition it is also depending on a bunch of unmaintained crates (listed on RUSTSEC too)

Environment

Zola version: Next branch

Expected Behavior

When I run cargo audit on this repo I get no alerts

Step to reproduce

Run cargo audit on the next branch

@Pi-Cla
Copy link
Author

Pi-Cla commented Mar 24, 2024

My proposed solution can be seen in this branch. (I have ran cargo test and all of the tests still pass)
Where ws is replaced with parity-ws (ws has yet to merge a PR that would fix RUSTSEC-2020-0043)
and cargo update was ran to fix the other two vulnerabilities.

See cargo-audit-zola-old.txt for the audit report before my changes and cargo-audit-zola-new.txt for the new audit report. I think markdown is a false positive? since this repo seems to have their own package called markdown.

The other three remaining alerts stem from our dependency on atty, net2 via an old version of mio, and encoding via an old version of lindera

@Pi-Cla
Copy link
Author

Pi-Cla commented Mar 24, 2024

I am less sure how to go about fixing the last three so any suggestions are appreciated

@Pi-Cla Pi-Cla changed the title [RUSTSEC-2024-0003] [RUSTSEC-2024-0019] and [RUSTSEC-2020-0043] [RUSTSEC-2024-0003] [RUSTSEC-2024-0019] and [RUSTSEC-2020-0043] (among many others) Mar 24, 2024
@Keats
Copy link
Collaborator

Keats commented Mar 25, 2024

Someone is working on some changes for the server (InDieTasten#1) cc @InDieTasten so I wouldn't bother changing the ws library for now.
As for the deprecated/unmaintained libraries I'll update most of them for the next version. There was one where the maintainer disappeared but I don't remember which one - guess i'll see soon.

@InDieTasten
Copy link

I can confirm I'm updating hyper and related dependencies right now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants