Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use url crate for handling URLs #2446

Open
clarfonthey opened this issue Mar 1, 2024 · 0 comments
Open

Use url crate for handling URLs #2446

clarfonthey opened this issue Mar 1, 2024 · 0 comments

Comments

@clarfonthey
Copy link
Contributor

Mentioned in #2311 but posting a dedicated issue to track it properly. Right now, the crate uses strings exclusively to track URLs, but we should probably use the url crate instead since it will allow earlier validation (e.g. passing an invalid base_url is an immediate error) and probably simplify some of the logic that existing code uses for URLs (replaced with dedicated methods).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant